Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JVM debugging docs #744

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Update JVM debugging docs #744

merged 3 commits into from
Aug 4, 2023

Conversation

dominikschubert
Copy link
Member

This new debugging setup is now compatible with both the legacy and the new provider as well as different Java runtimes.

@dominikschubert dominikschubert added the documentation Improvements or additions to documentation label Aug 2, 2023
@dominikschubert dominikschubert self-assigned this Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-744.surge.sh 🎊

joe4dev
joe4dev requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much-needed improvements 📈 👏

👉 The create-function command needs to be adjusted for Java.

🟢 Otherwise, I tested the setup on macOS and can confirm it works for java8.al2, java11, and java17.

content/en/user-guide/tools/lambda-tools/debugging/index.md Outdated Show resolved Hide resolved
content/en/user-guide/tools/lambda-tools/debugging/index.md Outdated Show resolved Hide resolved
content/en/user-guide/tools/lambda-tools/debugging/index.md Outdated Show resolved Hide resolved
content/en/user-guide/tools/lambda-tools/debugging/index.md Show resolved Hide resolved
joe4dev
joe4dev approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@dominikschubert dominikschubert merged commit 02c3bd3 into main Aug 4, 2023
3 checks passed
@dominikschubert dominikschubert deleted the lambda-jvm-debugging branch August 4, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

Assignees

@dominikschubert dominikschubert

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschubert @joe4dev