Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LocalStack Academy #742

Merged
merged 22 commits into from
Aug 23, 2023
Merged

Added LocalStack Academy #742

merged 22 commits into from
Aug 23, 2023

Conversation

webdev51
Copy link
Contributor

@webdev51 webdev51 commented Aug 2, 2023

Added a new section in the docs called LS Academy. Some screenshots:

Course Listing:

image

Lessons listing in a course:

image

Lesson details page:

image

@webdev51 webdev51 added the documentation Improvements or additions to documentation label Aug 2, 2023
@webdev51 webdev51 self-assigned this Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-742.surge.sh 🎊

@thrau thrau requested review from viren-nadkarni and removed request for thrau August 16, 2023 15:27
@thrau
Copy link
Member

thrau commented Aug 16, 2023

sorry i don't have enough time to thoroughly review this, i was hoping that @viren-nadkarni could maybe browse through it and give feedback on the content.

in terms of layout: it looks REALLY good. the navigation is super nice and the presentation looks wonderful.
just one minor nit: instead of having the button on the bottom of the lesson say "LEARN MORE" i would maybe call it "Next Lesson"

really great job everyone! 👏 @Nancy-Chauhan @webdev51 @tinyg210

Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @Nancy-Chauhan!

Overall the content and recordings are excellent. I only have a few nitpicks/suggestions.

I strongly recommend using one sentence per line in all the markdown files.

Also, I felt the language was a bit too marketing heavy, with too many instances of words like 'revolutionary' or 'exciting' or 'game-changing'. We might want to tone it down it future iteration since this is intended to be educational in nature :)

layouts/lessons/single.html Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-2/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-2/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-3/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-4/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-5/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-7/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-7/index.md Outdated Show resolved Hide resolved
content/en/academy/localstack-101/lesson-7/index.md Outdated Show resolved Hide resolved
@HarshCasper HarshCasper removed their request for review August 21, 2023 09:33
@Nancy-Chauhan Nancy-Chauhan removed the request for review from SimonWallner August 21, 2023 14:25
Nancy-Chauhan and others added 2 commits August 22, 2023 11:56
Add start button on list.html
@Nancy-Chauhan Nancy-Chauhan merged commit 27e1e21 into main Aug 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants