Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded links and replace them with references #1498

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Sep 25, 2024

Motivation

With recent PRs #1496 and #1490 we introduced some hard-coded links as bandages for link errors.

However, we should try to resort to ref shortcodes if possible.

Changes

  • Change links back to use the ref shortcode

@dfangl dfangl self-assigned this Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1498.surge.sh 🎊

@dfangl dfangl requested review from drauedo and removed request for thrau, giograno, silv-io and pinzon September 25, 2024 13:05
Copy link
Contributor

@drauedo drauedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing it.

@dfangl dfangl merged commit 6e6f205 into main Sep 25, 2024
5 checks passed
@dfangl dfangl deleted the fix-hardcoded-links branch September 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants