Adding sample for ddb and kinesis streams #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giograno
force-pushed
the
dynamodb-kinesis-stream
branch
from
a7cb99b
to
35ef51e
Compare
|
I added @baermat as reviewer to give feedback on whether the PR satisfies all the criteria needed for the samples |
thrau
approved these changes
Jun 9, 2023
baermat
requested changes
Jun 15, 2023
dynamodb-kinesis-stream/Makefile
Outdated
|
|
||
| run: ## Deploy and run the sample locally | ||
| @(test -d .terraform || tflocal init) && tflocal apply --auto-approve | ||
| pip install boto3 |
There was a problem hiding this comment.
The pip install should probably be in the install section. Also it would probably make sense to put this into a venv to not cause problems on the host (we probably should put even the "command" installs into a venv to make it cleaner, but that's how it is right now across the samples). see e.g. https://github.com/localstack/localstack-pro-samples/blob/master/iot-basics/Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the sample we pitched today.