-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added keyring usage #22
Conversation
Hey @lnxpy, This PR has one downside, if the user has used the |
Also, consider updating the README file. Thanks, man! |
Isn't it better if we set the |
No, This is exactly what the program does currently with no added lines of code, I believe the issue I was trying to solve was too much of a hassle to implement, and a very impossible scenario to happen.
I already did, You're welcome :). |
We'll look into that issue later. Pay attention to the reviews that I left. Once they're satisfied, then consider updating the README. @sepehrrasooli |
Hey @lnxpy !, I just made the changes you requested, |
…th, also made minor changes in other files to reflect it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are awesome. Some minor changes are required though.
Thanks, I made the requested changes :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All perfect. :))
Awesome work man!
This PR will close Issue #19, I changed the token storage system from environment variables to keyring, Added a new
hey token [HEY_TOKEN]
command and changed README.MD to reflect the new changes.