Skip to content

Commit

Permalink
Auto merge of #127731 - veluca93:abi_checks, r=RalfJung
Browse files Browse the repository at this point in the history
Emit future-incompatibility lint when calling/declaring functions with vectors that require missing target feature

On some architectures, vector types may have a different ABI depending on whether the relevant target features are enabled. (The ABI when the feature is disabled is often not specified, but LLVM implements some de-facto ABI.)

As discussed in rust-lang/lang-team#235, this turns out to very easily lead to unsound code.

This commit makes it a post-monomorphization error to declare or call functions using those vector types in a context in which the corresponding target features are disabled, if using an ABI for which the difference is relevant. This ensures that these functions are always called with a consistent ABI.

See the [nomination comment](rust-lang/rust#127731 (comment)) for more discussion.

r? RalfJung

Part of rust-lang/rust#116558
  • Loading branch information
bors committed Oct 25, 2024
2 parents 771e0eb + 848af21 commit 3a6ace0
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 3a6ace0

Please sign in to comment.