Allow a custom memo on invoice #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talvasconcelos
force-pushed
the
custom_memo
branch
from
1a3bf13
to
46c7fdd
Compare
dni
approved these changes
Aug 29, 2024
|
Is this still a draft PR? |
I'd like it to be tested... and some opinions on the UX! It basically adds one more prompt before displaying the invoice for payment, asking if the user wants to have a different memo. It may, IMO, clutter the UX... I think there should be an extension for PoS, and the TPOS would just serve to get payments, else is getting too much "features" and moving away from the simplicity of receive a payment! Can't find where this was requested, i think it was @arcbtc Also related to #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.