Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed behavior: Install from pypi (
pip install bolt11
) succeeds, butbolt11 decode
fails withTypeError: 'type' object is not subscriptable
inutils.py
on line:This occurs because subscripting the built-in
tuple
type with type hints is only supported in Python 3.9 and later. The type hint should be changed toTuple
from thetyping
module, which is supported in Python 3.8 and later.Since the pypi package lists support as >=3.8.1, this PR adds a simple way to bring support to 3.8. After applying the fix
blot11 decode
works.On 3.8 - it fails
On 3.9 - it succeeds