Fixed v8::IdleNotification for nodejs 0.12 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
4 similar comments
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
Works on iojs too. ;) 👍 The idle_time_in_ms parameter for IdleNotification() is hardcoded and equal to 500ms. It is sufficient for me to make the gc run. |
|
👍 |
|
Tested w/ node.js 0.12.0 and latest io.js, works like a charm. |
|
👍 |
|
Works for me, too. Running Node 0.12.0 on Mac OS X 10.9.5. |
|
👍 |
|
available on npm as memwatch-next... waiting for pr merge... ;) |
|
@marcominetti thanks 👍 |
Link to the right git repository
|
@marcominetti can't do npm update when the path contains folders with spaces. This must have been introduced by your patch sice it works for memwatch 0.2.2 |
|
Fixing right now... wait some minutes... ;) |
|
👍 |
fix readme
fix(bindings): support for npm@3 flatness
Supporting now iojs 3.x branch.
include iojs-v3 in travis ci build
Now uses both IdleNotification and LowMemoryNotification to ensure 'stats' event is triggered. The gc function now accepts custom deadline in milliseconds for IdleNotification. In iojs/nodejs version 3.x the full collection could not indeed occur.
Use std::isnan and std::isinf when on linux.
Minor, but JSON for heapdiff was missing one bracket.
Update README.md
chore(ci): add Node 4, 5 & 6
license page is previously incorrect
Just a little typo?
aver --> after ?
update license page
Refer diretctly to @airbnb/node-memwatch
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.