CI: Fix Docker multi-platform builds #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah docker arch boot needs the fix too. |
Docker now seems to require specifying the platform for ARM. But add it for 386 too to make configuration generic. JFYI, local list of platforms: docker buildx inspect --bootstrap Platforms for the image(s): docker buildx imagetools inspect ubuntu:bionic Fixes: lkrg-org#356 Signed-off-by: Vitaly Chikunov <[email protected]>
vt-alt
force-pushed
the
docker-platform
branch
from
43b73be to
e1233d3
Compare
|
The grass is green. |
|
Thank you @vt-alt, this was quick! Indeed all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docker now seems to require specifying the platform for ARM. But add it for 386 too to make configuration generic.
Fixes: #356
How Has This Been Tested?
GA