Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reject audio-only VOD assets #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thomshutt
Copy link
Contributor

This is now supported in Catalyst API with livepeer/catalyst-api#843

@thomshutt thomshutt requested a review from a team as a code owner September 1, 2023 14:33
@thomshutt thomshutt requested a review from mjh1 September 1, 2023 14:33
@mjh1
Copy link
Contributor

mjh1 commented Sep 1, 2023

This probe call is no longer used by the upload task (#212), however I did notice it's still in use by 'transcode' (not transcode API) and 'import' tasks. @victorges could you remind me are these tasks in use anymore? If not would it be safe to delete them?

@victorges
Copy link
Member

@mjh1 Those are the legacy flows for VOD. Import is equivalent to the Upload today, while transcode was a "mutation" of existing assets like to ask for a different profile for the master rendition or something like that. I believe it is not used anywhere, we don't document it nor expose on SDKs at least, and I guess they might even be completely broken by now. You can make sure by looking for tasks of type import or transcode on the DB, but I think it should be mostly safe to delete yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants