allow scientific price notation #3253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
allow_scientific_price_notation
branch
from
120a185
to
f270b11
Compare
This commit ensures that orchestrators can specify pricing using the scientific notation.
rickstaa
force-pushed
the
allow_scientific_price_notation
branch
from
f270b11
to
7448c45
Compare
rickstaa
commented
Nov 15, 2024
| @@ -1,5 +1,8 @@ | |||
| # Unreleased Changes | |||
|
|
|||
| - [#3253](https://github.com/livepeer/go-livepeer/pull/3253) - Allow orchestrators to specify pricing using scientific notation. | |||
| - [#3248](https://github.com/livepeer/go-livepeer/pull/3248) - Provide AI orchestrators with a way to specify `pricePerUnit` as a float. | |||
There was a problem hiding this comment.
@leszko, @ad-astra-video I noticed I forgot this in the last pull request.
This commit removes some unnesesary changes in the TestParsePricePerUnit function I introduced.
|
The docs also have been updated in livepeer/docs#689. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This pull request ensures that orchestrators can specify pricing using the scientific format.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass