-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selection algo filtering on max price fixed #3179
Open
ad-astra-video
wants to merge
3
commits into
livepeer:master
Choose a base branch
from
ad-astra-video:ai-video-fix-zero-max-price
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: selection algo filtering on max price fixed #3179
ad-astra-video
wants to merge
3
commits into
livepeer:master
from
ad-astra-video:ai-video-fix-zero-max-price
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
reviewed
Sep 23, 2024
victorges
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
server/selection_algorithm_test.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding tests 🙏
Co-authored-by: Victor Elias <[email protected]>
I updated for suggested change. Learned something new, did not know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes behavior of gateway when no max price is set.
0
maxPrice will return to being no max price filter enabled.The addition of maxPricePerCapability included initializing a zero max price by default so the map is fully initialized. This broke the
filterByMaxPrice
function that checked for an unsetmaxPrice
ofnil
.Specific updates (required)
filterByMaxPrice
function inselection_algorithm.go
to check for 0 rather than checking for nilHow did you test each of these updates (required)
Added new test and ran all tests in selection_algorithm_test.go
Does this pull request close any open issues?
Checklist:
make
runs successfully./test.sh
passX selection_algorithm_test.go pass.