Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add -pricePerGateway and deprecate -pricePerBroadcaster #3056

Merged
merged 8 commits into from
May 19, 2024

Commits on May 16, 2024

  1. refactor: add -pricePerGateway and deprecate -pricePerBroadcaster

    This commit adds the `pricePerGateway` flag and deprecates the `pricePerBroadcaster` flag
    per core team decision (details:
    https://discord.com/channels/423160867534929930/1051963444598943784/1210356864643109004).
    rickstaa committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b1b4106 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9ba3e3 View commit details
    Browse the repository at this point in the history
  3. refactor: remove redundant deprecation comment

    This commit removes the `PricePerBroadcaster` deprecation comment since
    this is already clear from the glog warning below.
    rickstaa committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9f0cf06 View commit details
    Browse the repository at this point in the history
  4. fix: correct the pricePerBroadcaster flag check

    This commit ensures that the deprecation condition for the `pricePerBroadcaster`
    flag properly handles the default empty string value.
    rickstaa committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ded5ad0 View commit details
    Browse the repository at this point in the history
  5. fix: ensure 'pricePerGateway' is used

    This commit ensures that the `pricePerGateway` is correctly used instead
    of the `pricePerBroadcaster` when it is set.
    rickstaa committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f83dec4 View commit details
    Browse the repository at this point in the history
  6. refactor: deprecate 'pricePerGateway' broadcasters property in favor …

    …of 'gateways'
    
    This commit updates the configuration to replace the `broadcasters` property
    specified under the `pricePerGateway` flag with `gateways`. Additionally, it
    ensures that a warning is issued when the deprecated property is still used.
    rickstaa committed May 16, 2024
    Configuration menu
    Copy the full SHA
    74fa79e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. test: fix TestParseGetBroadcasterPrices test

    This commit ensures that the TestParseGetBroadcasterPrices function uses
    the new getGatewayPrices function.
    rickstaa committed May 18, 2024
    Configuration menu
    Copy the full SHA
    bca3c3e View commit details
    Browse the repository at this point in the history
  2. test: rename TestParseGetBroadcasterPrices to reflect Gateway naming

    This commit updates the `TestParseGetBroadcasterPrices` function to
    `TestParseGetGatewayPrices` to align with the new node naming convention.
    rickstaa committed May 18, 2024
    Configuration menu
    Copy the full SHA
    569dbad View commit details
    Browse the repository at this point in the history