Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific prop types for audio and video track #681

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 1, 2023

previously some props like playsInline and controls weren't available for the video track component

Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: 0bdbfbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from Ocupe November 1, 2023 09:16
Copy link
Contributor

github-actions bot commented Nov 1, 2023

size-limit report 📦

Path Size
LiveKitRoom only 1.87 KB (0%)
LiveKitRoom with VideoConference 30.58 KB (0%)
All exports 35.81 KB (0%)

Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@lukasIO lukasIO merged commit d0b90cb into main Nov 1, 2023
@lukasIO lukasIO deleted the lukas/update-types branch November 1, 2023 13:05
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants