Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared logger for krisp hook #1044

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Use shared logger for krisp hook #1044

merged 2 commits into from
Dec 13, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Dec 7, 2024

This ensures it respects your log levels set on the SDK/components. I also clarified a message in case it helps for people who don't know what any of this stuff is 🤷🏻

@bcherry bcherry requested a review from lukasIO December 7, 2024 01:04
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: 35d56b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2024

size-limit report 📦

Path Size
LiveKitRoom only 6 KB (0%)
LiveKitRoom with VideoConference 29.76 KB (0%)
All exports 36.6 KB (0%)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bcherry
Copy link
Contributor Author

bcherry commented Dec 13, 2024

not sure why changeset bot didn't update the status but i added a changeset a few days ago

@bcherry bcherry merged commit 207ce97 into main Dec 13, 2024
3 checks passed
@bcherry bcherry deleted the bcherry/krisp-quiet branch December 13, 2024 18:38
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants