Fix releasing of local tracks in prejoin (#844)

livekit · Apr 25, 2024 · b8d9ea5 · b8d9ea5
1 parent 958dba5
commit b8d9ea5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/.changeset/shaggy-actors-perform.md b/.changeset/shaggy-actors-perform.md
@@ -0,0 +1,5 @@
+---
+"@livekit/components-react": patch
+---
+
+Fix releasing of local tracks in prejoin
diff --git a/packages/react/src/prefabs/PreJoin.tsx b/packages/react/src/prefabs/PreJoin.tsx
@@ -63,13 +63,11 @@ export function usePreviewTracks(
 
   React.useEffect(() => {
     let needsCleanup = false;
+    let localTracks: Array<LocalTrack> = [];
     trackLock.lock().then(async (unlock) => {
       try {
-        tracks?.forEach((track) => {
-          track.stop();
-        });
         if (options.audio || options.video) {
-          const localTracks = await createLocalTracks(options);
+          localTracks = await createLocalTracks(options);
 
           if (needsCleanup) {
             localTracks.forEach((tr) => tr.stop());
@@ -90,11 +88,11 @@ export function usePreviewTracks(
 
     return () => {
       needsCleanup = true;
-      tracks?.forEach((track) => {
+      localTracks.forEach((track) => {
         track.stop();
       });
     };
-  }, [JSON.stringify(options)]);
+  }, [JSON.stringify(options), onError, trackLock]);
 
   return tracks;
 }