Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of bundle settings #550

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

ladvoc
Copy link
Contributor

@ladvoc ladvoc commented Jan 16, 2025

Summary of changes:

  • Report error when required bundle settings are not in place for broadcast screen capture.
  • Introduce BundleInfo property wrapper to reduce code duplication.

- Report error when required bundle settings are not in place for screen capture.
- Introduce `BundleInfo` property wrapper to reduce code duplication.
Copy link
Member

@hiroshihorie hiroshihorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks neater !

@hiroshihorie hiroshihorie merged commit 8994740 into livekit:main Jan 17, 2025
11 of 12 checks passed
@ladvoc ladvoc deleted the bundle-settings branch January 18, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants