-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RPC feature #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks good !
Applied format & moved code to a separate file (extension) to organize.
Was just wondering if the Public APIs are "Swifty" enough 🧐
I could make it more swifty like this: Only downside is it loses consistency with other sdks in parameter structure. i was also thinking that maybe it would be better to revise across all SDKs to a separate construct attached to room e.g. |
This reverts commit c8e6d49.
@hiroshihorie I made those changes then reverted them while writing the docs because the way the docs are written it really is a lot nicer if all platforms have the same method names |
Pretty much identical to livekit/client-sdk-android#578
I included tests which mock the underlying data channel sending and receiving to test both sides in the same SDK app instance.