Expose init from string for Participant.Identity #543
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ming-chu
force-pushed
the
feature/public-constructor-for-participant-id
branch
2 times, most recently
from
6843b2e to
2ca2580
Compare
|
@ming-chu Can you sign the CLA ? |
hiroshihorie
approved these changes
Jan 13, 2025
ming-chu
force-pushed
the
feature/public-constructor-for-participant-id
branch
from
2ca2580 to
601ee39
Compare
|
@hiroshihorie Thank you for your time, I just rebase the branch and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have RoomOptions and it contains DataPublishOptions with destinationIdentities with type
Participant.Identity.I think it will be more convenient if we change the access level to public. ❤️