Bug unsupported file format 'public.heic' #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod for obtaining image representations on devices running iOS versions below 17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing remote sharing using LiveKit, we encountered an error on the iPad 5th generation running iPadOS 16.7.10 when converting a buffer to a JPEG representation. The suggested solution is to avoid using the native .jpgedRepresentation method, as it appears to contain a bug, and instead handle the conversion manually. After applying this approach, the error seems to be resolved.
The error logged in the Console app was:
This issue did not occur on newer devices with higher iOS versions and it worked correctly on newer devices like the iPhone SE (2nd generation) with iOS 15.5. This suggests the problem is specific to platform 16.7.10.
This error caused the screen-sharing session to be interrupted after several occurrences. After changes session was stable.
Please review this change and consider potential improvements.
PS: I have also removed the code responsible for scale factor buffering, as I did not observe any usage of it. If this removal was a mistake, please let me know.