Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous VideoView internal state #348

Merged
merged 8 commits into from
Mar 2, 2024
Merged

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Feb 26, 2024

Update VideoView's internal state synchronously so properties such as avSampleBufferDisplayLayer can be accessed immediately.

@hiroshihorie hiroshihorie marked this pull request as ready for review February 27, 2024 06:04
@hiroshihorie
Copy link
Member Author

hiroshihorie commented Feb 27, 2024

If I enforce all properties of VideoView to be accessed from main thread, I can simplify a lot of internal code.
UI components, inheriting from UIView should always be accessed from main thread, so it should be ok.
But I wonder if I make the change, how will it affect current users.

If current users are using VideoView correctly from main thread, nothing will break.

@hiroshihorie hiroshihorie merged commit bca5593 into main Mar 2, 2024
7 checks passed
@hiroshihorie hiroshihorie deleted the fix-videoview-state branch March 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant