Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Multi-Codec Simulcast usage by setting backupCodec to true #923

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

davidzhao
Copy link
Member

Currently it requires too many parameters to turn on the feature. The defaults were also dependent on input resolution. Making this optional and picking sane defaults.

Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: f672f7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 3, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 77.13 KB (+0.03% 🔺)
dist/livekit-client.umd.js 82.66 KB (+0.03% 🔺)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@@ -78,7 +78,7 @@ const appActions = {
const autoSubscribe = (<HTMLInputElement>$('auto-subscribe')).checked;
const e2eeEnabled = (<HTMLInputElement>$('e2ee')).checked;

setLogLevel(LogLevel.info);
setLogLevel(LogLevel.debug);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, I'm finding myself having to change this each time I use it. it was getting annoying.

@davidzhao davidzhao merged commit 89557f4 into main Nov 3, 2023
2 checks passed
@davidzhao davidzhao deleted the dz-simplify-ms branch November 3, 2023 16:39
@github-actions github-actions bot mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants