Do not allow VP9 publishing on FF #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since FF does not support SVC, and we require SVC for VP9, it will not be able to support VP9 publishing. Previously FF didn't support `getCapabilities`, so supportsVP9 check was passing for it. As much as I hate browser checks, there isn't another way to check for SVC publishing.
🦋 Changeset detectedLatest commit: 5d5c73c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FF does not support SVC, and we require SVC for VP9, it will not be able to support VP9 publishing.
Previously FF didn't support
getCapabilities, so supportsVP9 check was passing for it. As much as I hate browser checks, there isn't another way to check for SVC publishing.