Improve default device handling #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
bcherry
approved these changes
Jan 8, 2025
davidzhao
approved these changes
Jan 9, 2025
src/room/Room.ts
Outdated
| typeof FinalizationRegistry !== 'undefined' && | ||
| new FinalizationRegistry((cleanup: () => void) => { | ||
| cleanup(); | ||
| console.info('cleaning up room'); |
There was a problem hiding this comment.
nit: should this be info or debug?
Merged
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves default device handling across browsers.
For chrome we can rely on
defaultfor audio devices, for other browsers and video in chrome, the default device is the first device that's returned byenumerateDevices.I tried to annotate all changes with code comments that explain the reasoning, but please ask if anything seems unclear.