feat: support gemini llm in google plugin #1382
Conversation
🦋 Changeset detectedLatest commit: b55fffa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
livekit-plugins/livekit-plugins-google/livekit/plugins/google/_utils.py
Outdated
Show resolved
Hide resolved
mypy.ini
Outdated
| [mypy] | ||
|
|
||
| [mypy-google.genai.*] | ||
| ignore_missing_imports = True |
There was a problem hiding this comment.
I guess this is just ignoring the types too?
There was a problem hiding this comment.
Yeah, we might just have to wait till their sdk add py.typed
There was a problem hiding this comment.
What I mean is that we don't have to necessarily wait
https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
There was a problem hiding this comment.
I don't think their package is fully typed according to the last CI run: https://github.com/livekit/agents/actions/runs/12853743478/job/35837266341?pr=1382
While it's worth trying.. my 2c is to focus our typing exercise in our own code.. vs being concerned about how third party libs are being typed
There was a problem hiding this comment.
Checking the errors inside the above CI, the types errors seems related to our code, not their code tho
There was a problem hiding this comment.
ah my bad.. I misread the package as coming from them.. agreed we should fix our types.
There was a problem hiding this comment.
@theomonnom I've updated code to fix types, is this ready to merge?
| @@ -19,6 +19,7 @@ | |||
| "watchfiles", | |||
| "anthropic", | |||
| "websockets.client", | |||
| "root", | |||
There was a problem hiding this comment.
| "root", |
we can't do that
There was a problem hiding this comment.
root is the parent of all loggers
There was a problem hiding this comment.
ah my bad. I will remove in next pr (gemini transcriber)
No description provided.