Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Transcriber session with Google realtime API #1321
Support Transcriber session with Google realtime API #1321
Changes from 15 commits
2ba5598
4889301
06d60ba
4800261
97f5040
f5249f4
61da56a
a88281b
3ac01ac
aee4c1c
f42cbe1
99c4fa7
3911037
7eb6766
e8617e8
a6b378b
c624fba
fc10e5e
9e3b020
e88744e
fecda9f
9d8f732
906c22b
25003f1
5019d62
71685ea
019e90a
8579fb7
e5a413a
fc3c571
dc5c258
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you include comments on why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we should interrupt here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we call this function when speech is interrupted as well. They likely made some changes, but now Gemini returns
server.turn_complete
instead ofserver.interrupted
when interrupted. It's confusing. In both cases, we are calling this function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code here is hard to follow, really sad we don't have types (it's unclear what is the structure of the dicts)