Merge pull request #969 from liudger/bugfix/test-coverage

Bugfix: tests coverage
liudger · Oct 8, 2024 · 9bd5b38 · 9bd5b38
2 parents c3bf8ca + 4367fdb
commit 9bd5b38
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -19,12 +19,12 @@ jobs:
         python: ["3.12"]
     steps:
       - name: ⤵️ Check out code from GitHub
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
+        uses: actions/checkout@v4.2.1
       - name: 🏗 Set up Poetry
         run: pipx install poetry
       - name: 🏗 Set up Python ${{ matrix.python }}
         id: python
-        uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5
+        uses: actions/setup-python@v5.2.0
         with:
           python-version: ${{ matrix.python }}
           cache: 'poetry'
@@ -37,29 +37,30 @@ jobs:
       - name: 🚀 Run pytest
         run: poetry run pytest --cov bsblan tests
       - name: ⬆️ Upload coverage artifact
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3
+        uses: actions/upload-artifact@v4.4.1
         with:
           name: coverage-${{ matrix.python }}
+          include-hidden-files: true
           path: .coverage
 
   coverage:
     runs-on: ubuntu-latest
     needs: pytest
     steps:
       - name: ⤵️ Check out code from GitHub
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
+        uses: actions/checkout@v4.2.1
         with:
           fetch-depth: 0
       - name: ⬇️ Download coverage data
-        uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3
+        uses: actions/download-artifact@v4.1.8
       - name: 🏗 Set up Poetry
         run: pipx install poetry
       - name: 🏗 Set up Python ${{ env.DEFAULT_PYTHON }}
         id: python
-        uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5
+        uses: actions/setup-python@v5.2.0
         with:
           python-version: ${{ env.DEFAULT_PYTHON }}
-          cache: 'poetry'
+          cache: "poetry"
       - name: 🏗 Install workflow dependencies
         run: |
           poetry config virtualenvs.create true
@@ -71,10 +72,15 @@ jobs:
           poetry run coverage combine coverage*/.coverage*
           poetry run coverage xml -i
       - name: 🚀 Upload coverage report
-        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4
+        uses: codecov/codecov-action@v4.6.0
       - name: SonarCloud Scan
-        if: github.repository_owner == 'frenck'
-        uses: SonarSource/sonarcloud-github-action@eb211723266fe8e83102bac7361f0a05c3ac1d1b # v3.0
+        if: github.event.pull_request.head.repo.fork == false
+        uses: SonarSource/sonarcloud-github-action@v3.1.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          args: >
+            -Dsonar.projectKey=liudger_python-bsblan
+            -Dsonar.organization=liudger
+            -Dsonar.python.coverage.reportPaths=coverage.xml
diff --git a/sonar-project.properties b/sonar-project.properties
@@ -13,5 +13,5 @@ sonar.sourceEncoding=UTF-8
 sonar.sources=src
 sonar.tests=tests
 
-sonar.python.version=3.10, 3.11
+sonar.python.version=3.12
 sonar.python.coverage.reportPaths=coverage.xml