close #1486 #1501
Closed
close #1486 #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisphilar
requested changes
Aug 23, 2023
| @@ -177,15 +177,15 @@ def dimensional_parameters(self) -> dict[str, float | int]: | |||
| try: | |||
| return { | |||
| "alpha1 [-]": round(self._theta, 3), | |||
| "1/alpha2 [day]": round(self._tau / 24 / 60 / self._kappa), | |||
| "1/alpha2 [day]": round(self._tau / 24 / 60 / self._kappa) if self._kappa != 0 else np.NaN, | |||
There was a problem hiding this comment.
Sorry for my missing in the discussion #1486, but the same error could be raised for the other parameters except for theta. If rho_i = 0 and sigma = 0 are acceptable, could you remove the ZeroDivisionError and add "if" statements to the parameters?
Just a matter of preference, but we could remove != 0 because if not 0: is always True.
| @@ -163,7 +163,7 @@ def dimensional_parameters(self) -> dict[str, float | int]: | |||
| """Calculate dimensional parameter values. | |||
| Raises: | |||
| ZeroDivisionError: either kappa or rho_i for i=1,2,3 or sigma value was over 0 | |||
| ZeroDivisionError: rho_i for i=1,2,3 or sigma value was 0 | |||
| Returns: | |||
There was a problem hiding this comment.
Please add | None to the type hint and add "or None" to line 171 etc. for documentation.
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
8 times, most recently
from
3f2215b
to
db12452
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
2 times, most recently
from
5615635
to
12224c4
Compare
|
@karanjogi , |
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
5 times, most recently
from
99af80b
to
a2179d6
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
from
a2179d6
to
b4303de
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
4 times, most recently
from
13eff2d
to
c517bb1
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
3 times, most recently
from
c4c23b4
to
48adb28
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
2 times, most recently
from
0502114
to
8ca92d9
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
4 times, most recently
from
a10412a
to
c102012
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
2 times, most recently
from
e5e9d23
to
fc15801
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
4 times, most recently
from
feb5a10
to
1490caa
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
3 times, most recently
from
d4829d8
to
fe27725
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
4 times, most recently
from
b031992
to
dad8178
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
4 times, most recently
from
254b379
to
24dacfe
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
from
24dacfe
to
4a058b5
Compare
github-actions
bot
force-pushed
the
karanjogi/issue1486
branch
from
4a058b5
to
222c3dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
[Bug] Error when the number of Fatal cases are not changing with SIR-D model #1486
What was changed
Edited SIRD, SIRF and SEWIRF models to have a condition in case Fatal cases didn't change for a phase.
Also added a test case for the above models to check that the models do not break after the changes.