Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove TODO's #92

Merged
merged 3 commits into from
Dec 5, 2024
Merged

chore: Remove TODO's #92

merged 3 commits into from
Dec 5, 2024
+11 −36

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Dec 2, 2024

No description provided.

@bingen bingen self-assigned this Dec 2, 2024
danielattilasimon
danielattilasimon approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@danielattilasimon
Copy link
Contributor

Technically, there are some leftover @audit comments that are now resolved and could be removed. For example:

/// @audit This is wrong unless we enforce a reset on deposit and withdrawal

Since we do enforce a reset, this sounds odd now.

@bingen bingen merged commit ce7e968 into main Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielattilasimon danielattilasimon danielattilasimon approved these changes

@RickGriff RickGriff Awaiting requested review from RickGriff

Assignees

@bingen bingen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bingen @danielattilasimon