fix: Emit both amounts coming from LQTYStaking and total ones on unst… #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/UserProxy.sol
Outdated
| emit Unstake(_amount, _recipient, lusdAmount, ethAmount); | ||
| emit Unstake( | ||
| _recipient, | ||
| _amount, |
There was a problem hiding this comment.
In my opinion _amount is meaningless, and we should calculate the balance difference like we do for LUSD & ETH and use that instead. This is because you pass any amount higher than your stake, and LQTYStaking will internally truncate it to the maximum withdrawable amount.
If you pass any amount higher than your stake, and LQTYStaking will internally truncate it to the maximum withdrawable amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aking