Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Upscale TS to reduce precision loss #68

Merged

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Nov 1, 2024

Upscale Timestamps by 1e18 to make precision loss errors massively less impactful

Invariant Testing

https://getrecon.xyz/shares/620a39ea-2148-45eb-91e6-4cc13027a205

ID of job to re-use
c8a728bb-89ee-43de-9785-ea34815353c9

We expect ONLY absolute strict properties to fail, lax properties should be maintained
TODO: Polish and update the last few properties

TODO

  • Review Properties
  • Ensure that Properties breaking have an impact below 10e19 (10 LQTY over the lifetime)
  • Setup automated tests for Fixes
  • Re-check overflows and flows
  • Document Spec Changes
  • Document Fixes for ChainSecurity and Dedaub

@GalloDaSballo GalloDaSballo changed the title Fix temp invariant align bribes Fix: Upscale TS to reduce precision loss Nov 1, 2024
@GalloDaSballo GalloDaSballo merged commit 9bc1dd9 into fix-audit-and-invariants Nov 3, 2024
2 of 3 checks passed
@danielattilasimon danielattilasimon deleted the fix-temp-invariant-align-bribes branch November 13, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant