Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temp invariant align bribes #67

Merged
merged 14 commits into from
Oct 31, 2024
Merged

Fix temp invariant align bribes #67

merged 14 commits into from
Oct 31, 2024

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Oct 30, 2024 •
edited
Loading

Critical Insolvency Repro

forge test --match-test test_governance_claimForInitiativeDoesntRevert_5 -vv

PR Changes

Computes epochEnd

        uint32 epochEnd = uint32(governance.EPOCH_START()) + uint32(_epoch) * uint32(governance.EPOCH_DURATION());

https://getrecon.xyz/shares/c7cfcdce-28bc-475f-ba9a-67609a746cad

  • Do the invariants hold
  • Should we change to epochEnd -1 to prevent quick votes on other chains?

@GalloDaSballo GalloDaSballo changed the base branch from main to dev October 31, 2024 08:36
@GalloDaSballo GalloDaSballo changed the base branch from dev to fix-audit-and-invariants October 31, 2024 08:37
@GalloDaSballo GalloDaSballo merged commit 33ece7f into fix-audit-and-invariants Oct 31, 2024
1 of 2 checks passed
@GalloDaSballo GalloDaSballo mentioned this pull request Oct 31, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GalloDaSballo @nican0r