Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invariant Testing Run, with revert checks on all view functions
https://getrecon.xyz/dashboard/jobs/66d7b004-e279-406c-baf5-35b7398f6557
Change
lqtyToVotes
to use a uint120, proven to be safe since the max is bigger than the product of the max uint32 and max of uint88Also improves packing of storage slots, saving gas, with (I believe) no additional security risk
WARNING!
I have altered the logical flow of how
boldAccrued
is computed, PLEASE REVIEW THIS!Update
Removed references to uint120 in src (except UniV4)
Updated Invariant Testing to check for revert cases
Packed the
boldAccrued
into the snapshothttps://getrecon.xyz/shares/a8a1e527-8dee-454f-8556-384c9d5387e7
Missing Tests
Missing Polish
I made all the snapshot logic "view" and conditionally accruing
Should we change the code to always have only one return value even on view?