Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fix properties #58

Closed
wants to merge 5 commits into from
Closed

Dev fix properties #58

wants to merge 5 commits into from

Conversation

GalloDaSballo
Copy link
Collaborator

@GalloDaSballo GalloDaSballo commented Oct 28, 2024 •
edited
Loading

  • Unit test for Total Allocated LQTY when removing from DISABLED property
  • Invariant test for Total Allocated LQTY when removing from DISABLED property
  • Fix of accounting error
  • Explicit check for non negative inputs in allocateLQTY

Invariant Changes

  • More explicit, inductive based testing for all accounting math
  • For each user allocation, account for the power they are using, add a check to ensure that removing is idempotent, even if they changed their user state - Implemented in exp-reset-all

@GalloDaSballo GalloDaSballo mentioned this pull request Oct 29, 2024
Merged
11 tasks
@danielattilasimon danielattilasimon deleted the dev-fix-properties branch November 13, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GalloDaSballo