Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Fix: Fix a small Spec bug #52

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Optional Fix: Fix a small Spec bug #52

merged 3 commits into from
Oct 21, 2024

Conversation

GalloDaSballo
Copy link
Collaborator

The spec allows voting on UNREGISTERABLE initiatives
Meaning they can come back to being claimable if not actually unregistered

This technically can still happen if the votingThreshold changes and nobody calls unregistered

There's a bunch of broken tests in this PR, and it would make sense to fully reason around this fix

I believe the fix is not necessary, but the spec bug is legitimate and should be documented

@GalloDaSballo GalloDaSballo changed the base branch from main to dev October 21, 2024 11:56
@jltqy jltqy merged commit f529432 into dev Oct 21, 2024
2 of 3 checks passed
@GalloDaSballo GalloDaSballo deleted the exp-unregisterable-fsm branch October 22, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants