Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int to uint casting overflow #3

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

jltqy
Copy link
Collaborator

@jltqy jltqy commented Oct 4, 2024

No description provided.

@jltqy jltqy marked this pull request as ready for review October 4, 2024 14:32
@jltqy jltqy requested review from bingen and ColinPlatt October 4, 2024 14:32
@jltqy jltqy changed the title Fix/vote check Fix int to uint casting overflow Oct 7, 2024
@GalloDaSballo GalloDaSballo changed the base branch from main to dev October 10, 2024 16:39
@GalloDaSballo GalloDaSballo changed the base branch from dev to dev-governance-refactor October 13, 2024 12:54
@GalloDaSballo GalloDaSballo merged commit eb2e1ec into dev-governance-refactor Oct 13, 2024
2 of 3 checks passed
@GalloDaSballo GalloDaSballo deleted the fix/voteCheck branch October 14, 2024 16:21
danielattilasimon added a commit that referenced this pull request Dec 3, 2024
Timeline:
 - epoch #1: initial initiatives are in warmup
 - epoch #2: initial initiatives can be voted on
 - epoch #3: registration opens for new initiatives

In practice, we will "skip" epoch #1 by deploying with `EPOCH_START`
backdated by one `EPOCH_DURATION`, so that initial initiatives can
be voted on right from the get-go.
danielattilasimon added a commit that referenced this pull request Dec 6, 2024
feat: disallow registration before epoch #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants