Code

Dev governance refactor#16

Code

Merged

GalloDaSballo merged 104 commits intodevliquity/V2-gov:devfrom dev-governance-refactorliquity/V2-gov:dev-governance-refactorCopy head branch name to clipboardOct 16, 2024

+2,423-339

Commits

Commits on Oct 4, 2024

• test for vote amount

  ColinPlatt

  committed
  958749f

  Copy full SHA for 958749f

• Restrict deltas to int96 and assert <= 2**88

  jltqy

  committed
  f66f972

  Copy full SHA for f66f972

Commits on Oct 10, 2024

• fix: compilation - safeTransfer

  GalloDaSballo

  committed
  f1f741e

  Copy full SHA for f1f741e

• feat: introduce lastEpochClaim

  GalloDaSballo

  committed
  d56007f

  Copy full SHA for d56007f

• feat: invariant - can only claim or unregister per epoch

  GalloDaSballo

  committed
  66f081c

  Copy full SHA for 66f081c

• fix: test that is broken

  GalloDaSballo

  committed
  bd34a83

  Copy full SHA for bd34a83

• feat: getInitiativeState

  GalloDaSballo

  committed
  f63a541

  Copy full SHA for f63a541

• feat: initial fixes around maintaining storage for disabled proposals

  GalloDaSballo

  committed
  a06b94b

  Copy full SHA for a06b94b

• Merge branch 'main' into fix/voteCheck

  GalloDaSballo

  authored
  1be0fb6

  Copy full SHA for 1be0fb6

Commits on Oct 11, 2024

• feat: test_crit_accounting_mismatchand test_canAlwaysRemoveAllocation

  GalloDaSballo

  committed
  84fc1e8

  Copy full SHA for 84fc1e8

• feat: use constant for disabled initiatives

  GalloDaSballo

  committed
  dcc3dd0

  Copy full SHA for dcc3dd0

• chore: cleanup + isolate overflow checks

  GalloDaSballo

  committed
  efab2c6

  Copy full SHA for efab2c6

• Restrict deltas to int88

  jltqy

  committed
  e9d117d

  Copy full SHA for e9d117d

• feat: FSM is enforced

  GalloDaSballo

  committed
  a816b67

  Copy full SHA for a816b67

• chore: remove logs

  GalloDaSballo

  committed
  2c52bc3

  Copy full SHA for 2c52bc3

• feat: return 0 on duplicate claim

  GalloDaSballo

  committed
  1fee011

  Copy full SHA for 1fee011

• chore: re-order functions

  GalloDaSballo

  committed
  838b48c

  Copy full SHA for 838b48c

• feat: enum initiative status and improvement to getInitiativeState

  GalloDaSballo

  committed
  7f66112

  Copy full SHA for 7f66112

• feat: snapshot asserts

  GalloDaSballo

  committed
  9e8fd9e

  Copy full SHA for 9e8fd9e

• chore: future notes

  GalloDaSballo

  committed
  e4ccbc0

  Copy full SHA for e4ccbc0

• feat: counted is gone

  GalloDaSballo

  committed
  480c077

  Copy full SHA for 480c077

• feat: counted is gone

  GalloDaSballo

  committed
  ac4d1eb

  Copy full SHA for ac4d1eb

Commits on Oct 12, 2024

• feat: introduce vetos as part of snapshot storage

  GalloDaSballo

  committed
  9c9f77c

  Copy full SHA for 9c9f77c

• feat: use vetos from snapshot to determine FSM

  GalloDaSballo

  committed
  10e3659

  Copy full SHA for 10e3659

• chore: remove unused variable

  GalloDaSballo

  committed
  bbc9dc8

  Copy full SHA for bbc9dc8

• feat: use getInitiativeState for unregisterInitiative

  GalloDaSballo

  committed
  27b33db

  Copy full SHA for 27b33db

• chore: comments

  GalloDaSballo

  committed
  0584ac0

  Copy full SHA for 0584ac0

• fix: vetos, lastCountedEpoch and votes FSM follow the spec

  GalloDaSballo

  committed
  c1945bf

  Copy full SHA for c1945bf

Commits on Oct 13, 2024

• Merge branch 'dev-governance-refactor' into fix/voteCheck

  GalloDaSballo

  committed
  eb2e1ec

  Copy full SHA for eb2e1ec

• fix: compilation

  GalloDaSballo

  committed
  3adf6dc

  Copy full SHA for 3adf6dc

• feat: broken | math tests

  GalloDaSballo

  committed
  77fe12b

  Copy full SHA for 77fe12b

Commits on Oct 14, 2024

• feat: ref vs lib tests

  GalloDaSballo

  committed
  a4af757

  Copy full SHA for a4af757

• Merge branch 'dev' into dev-governance-refactor

  GalloDaSballo

  committed
  78a4e55

  Copy full SHA for 78a4e55

• fix: compilation

  GalloDaSballo

  committed
  03c5315

  Copy full SHA for 03c5315

• feat: fuzz tests for encoding + decoding allocation

  nican0r

  committed
  a932aa0

  Copy full SHA for a932aa0

• test: unit test for reproducing issue with encoding

  nican0r

  committed
  65f466b

  Copy full SHA for 65f466b

• fix: encoded value passed in for decoding

  nican0r

  committed
  9e10b09

  Copy full SHA for 9e10b09

• Merge branch 'dev-governance-refactor' into allocation-encoding-tests

  GalloDaSballo

  committed
  d5b9a21

  Copy full SHA for d5b9a21

• Merge branch 'dev' into allocation-encoding-tests

  GalloDaSballo

  committed
  f5d30e8

  Copy full SHA for f5d30e8

• fix: random use of solmate

  GalloDaSballo

  committed
  629799f

  Copy full SHA for 629799f

• test: rational flow for allocating/claiming bribe

  nican0r

  committed
  e662cb7

  Copy full SHA for e662cb7

• feat: encode / deocde

  GalloDaSballo

  committed
  f4ca88f

  Copy full SHA for f4ca88f

• feat: testFail

  GalloDaSballo

  committed
  4bb1a58

  Copy full SHA for 4bb1a58

• Merge pull request #24 from liquity/allocation-encoding-tests

  Show description for e84c00d
  GalloDaSballo

  authored
  e84c00d

  Copy full SHA for e84c00d

• fix: bribe CEI

  GalloDaSballo

  committed
  3a6c038

  Copy full SHA for 3a6c038

• fix: cannot claim in the future

  GalloDaSballo

  committed
  af5132f

  Copy full SHA for af5132f

• feat: rational flow

  GalloDaSballo

  committed
  f118d1f

  Copy full SHA for f118d1f

• fix: use lib for encoding / decoding

  GalloDaSballo

  committed
  12f94ed

  Copy full SHA for 12f94ed

• chore: adding governance scaffolding

  nican0r

  committed
  79ab942

  Copy full SHA for 79ab942

• feat: property_GV01

  nican0r

  committed
  d94b2cd

  Copy full SHA for d94b2cd

Commits on Oct 15, 2024

• feat: adding properties and scaffolding from bribe-initiative-invar-tester

  nican0r

  committed
  2e38b40

  Copy full SHA for 2e38b40

• chore: uncommenting properties

  nican0r

  committed
  eae43cd

  Copy full SHA for eae43cd

• chore: updating properties table

  nican0r

  committed
  0d2e524

  Copy full SHA for 0d2e524

• Merge branch 'dev' into dev-governance-refactor

  GalloDaSballo

  committed
  0b1ab3a

  Copy full SHA for 0b1ab3a

• fix: add sanity checks to thresholds

  GalloDaSballo

  committed
  ceb0f7e

  Copy full SHA for ceb0f7e

• feat: move logic to allow removing lastCountedEpoch

  GalloDaSballo

  committed
  8b3670e

  Copy full SHA for 8b3670e

• feat: remove usage of lastCountedEpoch

  GalloDaSballo

  committed
  9109d98

  Copy full SHA for 9109d98

• feat: for packing

  GalloDaSballo

  committed
  089b968

  Copy full SHA for 089b968

• feat: view variants of snapshot functions

  GalloDaSballo

  committed
  b692f5b

  Copy full SHA for b692f5b

• chore: cleanup

  GalloDaSballo

  committed
  8e60ecb

  Copy full SHA for 8e60ecb

• chore: more cleanuop

  GalloDaSballo

  committed
  3a7fd77

  Copy full SHA for 3a7fd77

• feat: stateless checks use memory variables

  GalloDaSballo

  committed
  ab20d48

  Copy full SHA for ab20d48

• fix: 5.3

  GalloDaSballo

  committed
  d77fa12

  Copy full SHA for d77fa12

• fix: remove unnecessary threshold

  GalloDaSballo

  committed
  e39a3fd

  Copy full SHA for e39a3fd

• Merge pull request #34 from liquity/feat-dev-stateless-checks

  Show description for f964608
  GalloDaSballo

  authored
  f964608

  Copy full SHA for f964608

• Merge pull request #25 from liquity/bribe-claiming-unit-test

  Show description for d4a20e1
  GalloDaSballo

  authored
  d4a20e1

  Copy full SHA for d4a20e1

• Merge remote-tracking branch 'origin/gov-invar-tester-after-refactor' into dev-governance-refactor

  GalloDaSballo

  committed
  d4c2058

  Copy full SHA for d4c2058

• fix: deps

  GalloDaSballo

  committed
  0b72301

  Copy full SHA for 0b72301

• fix: medusa and signature

  GalloDaSballo

  committed
  d60e671

  Copy full SHA for d60e671

• fix: cryticToFoundry and overflow

  GalloDaSballo

  committed
  6c8de58

  Copy full SHA for 6c8de58

• fix: property

  GalloDaSballo

  committed
  cd7fba3

  Copy full SHA for cd7fba3

• fix: introduce more states to track initiative and fix invariant test

  GalloDaSballo

  committed
  dfefc27

  Copy full SHA for dfefc27

• chore: gas + docs

  GalloDaSballo

  committed
  c4da233

  Copy full SHA for c4da233

• feat: view vs non view properties

  GalloDaSballo

  committed
  3d192fa

  Copy full SHA for 3d192fa

• feat: mostly using FSM, can simplify a bit

  GalloDaSballo

  committed
  aed7a96

  Copy full SHA for aed7a96

• feat: commiting to using FSM

  GalloDaSballo

  committed
  c312fcb

  Copy full SHA for c312fcb

• feat: unregisterInitiative FSM equivalence

  GalloDaSballo

  committed
  02bf481

  Copy full SHA for 02bf481

• chore: comment

  GalloDaSballo

  committed
  121bede

  Copy full SHA for 121bede

• chore: comment

  GalloDaSballo

  committed
  5d34676

  Copy full SHA for 5d34676

• feat: simplify claim logic

  GalloDaSballo

  committed
  e80a9ce

  Copy full SHA for e80a9ce

Commits on Oct 16, 2024

• feat: pretty close to done

  GalloDaSballo

  committed
  5f863c3

  Copy full SHA for 5f863c3

• feat: cache data for unregisterInitiative

  GalloDaSballo

  committed
  cf0f98c

  Copy full SHA for cf0f98c

• gas: claimForInitiative

  GalloDaSballo

  committed
  3660391

  Copy full SHA for 3660391

• fix: remove extra SSTORE

  GalloDaSballo

  committed
  16bf1d3

  Copy full SHA for 16bf1d3

• feat: FSM + Crit notice

  GalloDaSballo

  committed
  6309c90

  Copy full SHA for 6309c90

• Merge branch 'exp-external-functions-fsm' into dev-governance-refactor

  GalloDaSballo

  committed
  ad3d9f8

  Copy full SHA for ad3d9f8

• gas: remove extra 0 check

  GalloDaSballo

  committed
  83657b5

  Copy full SHA for 83657b5

• chore: cleanup

  GalloDaSballo

  committed
  6b15ed6

  Copy full SHA for 6b15ed6

• fix: Critical accounting bug

  GalloDaSballo

  committed
  b45e6a6

  Copy full SHA for b45e6a6

• chore: future

  GalloDaSballo

  committed
  0ae541f

  Copy full SHA for 0ae541f

• feat: broken key test

  GalloDaSballo

  committed
  3927a88

  Copy full SHA for 3927a88

• chore: cleanup

  GalloDaSballo

  committed
  56b162d

  Copy full SHA for 56b162d

• chore: fixes to properties

  GalloDaSballo

  committed
  7d375b1

  Copy full SHA for 7d375b1

• chore: sample broken pro

  GalloDaSballo

  committed
  568f189

  Copy full SHA for 568f189

• feat: view acounting properties

  GalloDaSballo

  committed
  506bf03

  Copy full SHA for 506bf03

• fix: dorky bug

  GalloDaSballo

  committed
  60f12ae

  Copy full SHA for 60f12ae

• feat: broken property

  GalloDaSballo

  committed
  c81f05d

  Copy full SHA for c81f05d

• feat: trophies

  GalloDaSballo

  committed
  1541192

  Copy full SHA for 1541192

• chore: cleanuop

  GalloDaSballo

  committed
  85eecdd

  Copy full SHA for 85eecdd

• feat: e2e test + make invariant tests more reliable

  GalloDaSballo

  committed
  4581c3e

  Copy full SHA for 4581c3e

• chore: further simplify trophy

  GalloDaSballo

  committed
  b6fc28a

  Copy full SHA for b6fc28a

• feat: document the vote vs veto bug

  GalloDaSballo

  committed
  e4ef357

  Copy full SHA for e4ef357

• feat: e2e test for unregistering

  GalloDaSballo

  committed
  62ed071

  Copy full SHA for 62ed071

• chore: improved README

  GalloDaSballo

  committed
  e26ab76

  Copy full SHA for e26ab76