Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit review findings #1

Closed
wants to merge 1 commit into from
Closed

Fix audit review findings #1

wants to merge 1 commit into from

Conversation

jltqy
Copy link
Collaborator

@jltqy jltqy commented Sep 16, 2024

  • Test to repro the bug

What bug does this cause?

@jltqy jltqy changed the title Remove unnecessary conditional statement Fix audit review findings Sep 16, 2024
@GalloDaSballo GalloDaSballo changed the base branch from main to dev October 10, 2024 16:40
danielattilasimon added a commit that referenced this pull request Dec 3, 2024
Timeline:
 - epoch #1: initial initiatives are in warmup
 - epoch #2: initial initiatives can be voted on
 - epoch #3: registration opens for new initiatives

In practice, we will "skip" epoch #1 by deploying with `EPOCH_START`
backdated by one `EPOCH_DURATION`, so that initial initiatives can
be voted on right from the get-go.
danielattilasimon added a commit that referenced this pull request Dec 3, 2024
Timeline:
 - epoch 1: initial initiatives are in warmup
 - epoch 2: initial initiatives can be voted on
 - epoch 3: registration opens for new initiatives

In practice, we will "skip" epoch #1 by deploying with `EPOCH_START`
backdated by one `EPOCH_DURATION`, so that initial initiatives can
be voted on right from the get-go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants