-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable/Disable Items with authentification headers #1304
base: 2.x
Are you sure you want to change the base?
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have found some misspelling, please take a look.
I can make a new review when the problems are resolved. |
@albinmedoc I corrected the misspellings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found some more issues that need to be resolved
Sorry for not adding all suggestions at one time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks likes branch has conflicts that must be resolved, please rebase and fix conflicts. |
…rms for all users
@albinmedoc the merge conflicts should now be solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
@KodeStar can I get some feedback to this merge request. |
Sorry @tkolzer, looks good to me, add some details in the README on what it's for and how to use it and I'll merge it. |
It looks like the roles only work with folder type tags, is this expected behaviour? |
"controles" should probably be "controls" |
Use case:
New feature when enabled:
Authentification role
is added. This filed contains the role to witch the application or tag is displayed.Configuration:
AUTH_ROLES_ENABLE
.AUTH_ROLES_HEADER
andAUTH_ROLES_HTTP_HEADER
.AUTH_ROLES_ADMIN
.