Stack_Analyzer：Adapted to MagicEyes #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
…tformat Signed-off-by: LiuLingze <[email protected]>
…tformat Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
Signed-off-by: LiuLingze <[email protected]>
…tformat Signed-off-by: LiuLingze <[email protected]>
GorilaMond
requested review from
ziyangfu,
helight,
LinkinPF and
chenamy2017
as code owners
|
@ziyangfu 帮忙看看哈 |
ziyangfu
reviewed
Mar 19, 2024
| @@ -28,6 +29,7 @@ if (NOT EXISTS ${SRC_GEN_TARGET_DIR}) | |||
| message(STATUS "directory create success") | |||
| endif () | |||
|
|
|||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include/ ${SRC_GEN_TARGET_DIR}) | |||
There was a problem hiding this comment.
如果不想include名字太长，也可以的，建议最起码带上你的工具名，这样对以后的集成工具使用者比较友好。就是你在代码里 #include “stack_analyzer/.skel.h”， 而不是直接的 #include “.skel.h” 。下次提交pr的时候再改就行
ziyangfu
reviewed
Mar 19, 2024
嗯，你只要看是否符合你的工程框架，这块没问题就可以了，其他的内容我们来把控 |
好滴 |
如果框架工程没问题，你就可以先approve吧 |
ziyangfu
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.