Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs_watcher:libbpf_fs_watcher(添加了一个write系统调用) #714

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

sf1999817
Copy link
Contributor

Pull Request Template

Description/描述

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
此 pr 解决了什么问题
这个pr写了比较简易版的write的系统调用,这个礼拜会把这个代码再继续优化,之前写的代码有点问题,等修改后,和这个代码合并

Fixes # (issue)

Type of change /PR 类型

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?/ 测试方式

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist/检查列表

  • My code follows the style guidelines of this project /代码规范检查
  • I have performed a self-review of my own code / 自己已经检查代码
  • I have commented my code, particularly in hard-to-understand areas / 有代码注释,尤其是关键代码
  • I have made corresponding changes to the documentation /变更内容同步到了文档中
  • My changes generate no new warnings / 变更没有新产生告警
  • I have added tests that prove my fix is effective or that my feature works /对修改代码添加了测试用例
  • New and existing unit tests pass locally with my changes / 对单元测试也同步更新了

Signed-off-by: shangfan <[email protected]>
@@ -0,0 +1,63 @@
#include "vmlinux.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件头要加一下

@@ -0,0 +1,99 @@
#include <stdio.h>
#include <unistd.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也是文件头加一下

@helight helight changed the title libbpf_fs_watcher(添加了一个write系统调用) fs_watcher:libbpf_fs_watcher(添加了一个write系统调用) Mar 15, 2024
Copy link
Contributor

@13186379707 13186379707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码现在基本没有问题了,希望下个pr可以将fs_watcher项目的流水线完成

Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helight helight merged commit 490404a into linuxkerneltravel:develop Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants