feat: 终端日志规范改造 #193
Triggered via pull request
October 7, 2023 05:37
hundundadi
hundundadi
opened
#301
Status
Success
Total duration
1m 8s
Artifacts
–
Annotations
10 warnings
|
cppcheck:
src/customcommand/customcommandoptdlg.cpp#L648
Parameter 'oldCmdName' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
|
|
cppcheck:
src/main/dbusmanager.cpp#L80
Parameter 'fontType' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
|
|
cppcheck:
src/main/dbusmanager.cpp#L145
Parameter 'args' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
|
|
cppcheck:
src/main/mainwindow.cpp#L903
Condition 'runningCount!=0' is always true
|
|
cppcheck:
src/main/terminalapplication.cpp#L54
The function 'handleQuitAction' is never used.
|
|
cppcheck:
src/remotemanage/serverconfigoptdlg.cpp#L566
The function 'slotFileChooseDialog' is never used.
|
|
cppcheck:
src/views/termwidget.cpp#L1136
Parameter 'name' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
|
|
cppcheck:
src/views/termwidget.cpp#L1136
Parameter 'direction' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
|
|
cppcheck:
src/views/termwidgetpage.cpp#L324
Consider using std::find_if algorithm instead of a raw loop.
|
|
cppcheck
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|