Add support for Google Chromebooks #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archisman-panigrahi
force-pushed
the
main
branch
2 times, most recently
from
ee5ea39 to
2799d39
Compare
|
Please release a new version after merging, so that it would reach the users. |
linusg
reviewed
Sep 23, 2024
rpi_backlight/__init__.py
Outdated
| @@ -24,7 +24,7 @@ class BoardType(Enum): | |||
| #: Tinker Board 2 | |||
| TINKER_BOARD_2 = 3 | |||
| #: Microsoft Surface RT | |||
| MICROSOFT_SURFACE_RT = 4 | |||
| SURFACE_RT_OR_GOOGLE_CHROMEBOOK = 4 | |||
There was a problem hiding this comment.
Please call it GENERIC at this point
There was a problem hiding this comment.
The problem with generic is that, most generic devices have brightness control at sys/class/backlight/acpi_video0 or sys/class/backlight/intel_backlight (and those devices would be supported by i386 version of Raspberry Pi OS). Given that, what do you think we should do?
There was a problem hiding this comment.
This is a library intended to run on a raspberry pi board with the official raspberry pi display, edge cases like this don't matter
rpi_backlight/cli.py
Outdated
| } | ||
|
|
||
| BOARD_TYPE_TO_STRING = { | ||
| BoardType.RASPBERRY_PI: "raspberry-pi", | ||
| BoardType.TINKER_BOARD: "tinker-board", | ||
| BoardType.TINKER_BOARD_2: "tinker-board-2", | ||
| BoardType.MICROSOFT_SURFACE_RT: "microsoft-surface-rt", | ||
| BoardType.SURFACE_RT_OR_GOOGLE_CHROMEBOOK: "microsoft-surface-rt", |
archisman-panigrahi
force-pushed
the
main
branch
from
2799d39 to
a593375
Compare
|
How about now? |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ARM Chromebooks support running Debian and the Pixel desktop of RPi OS.
This commit adds support for them