Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Add wrapper for rust ffi doublets #302

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

FreePhoenix888
Copy link
Member

  • Add FfiLinks
  • Add CMakeLists
  • Add FfiTest
  • Add Platform.Data.Doublets.h

@FreePhoenix888 FreePhoenix888 changed the base branch from master to main March 27, 2022 07:14
@FreePhoenix888 FreePhoenix888 requested a review from Konard April 15, 2022 07:13
@FreePhoenix888 FreePhoenix888 self-assigned this Apr 15, 2022
@FreePhoenix888 FreePhoenix888 changed the title [C] Add ffi links [C] Add wrapper for rust ffi doublets Apr 15, 2022
c/src/FfiLinks.h Outdated Show resolved Hide resolved
c/src/FfiLinks.h Outdated Show resolved Hide resolved
c/src/FfiLinks.h Outdated Show resolved Hide resolved
c/src/FfiLinks.h Outdated Show resolved Hide resolved
c/src/FfiLinks.h Outdated Show resolved Hide resolved
c/src/FfiLinks.h Outdated Show resolved Hide resolved
c/src/LinksConstants.h Outdated Show resolved Hide resolved
c/src/LinksConstants.h Outdated Show resolved Hide resolved
c/tests/FfiTests.cpp Outdated Show resolved Hide resolved
Copy link
Member

@uselessgoddess uselessgoddess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to approve

c/CMakeLists.txt Outdated Show resolved Hide resolved
Comment on lines +7 to +9
set(CONAN_DISABLE_CHECK_COMPILER TRUE)
set(LINKS_PLATFORM_TESTS TRUE)
set(LINKS_PLATFORM_BENCHMARKS TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were banned in the terminal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't joke


project(Platform.Data.Doublets)

set(CONAN_DISABLE_CHECK_COMPILER TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o_o

c/CMakeLists.txt Outdated
Comment on lines 17 to 18


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

add_library(${PROJECT_NAME}.Library INTERFACE)
target_include_directories(${PROJECT_NAME}.Library INTERFACE src)

target_link_directories(${PROJECT_NAME}.Library INTERFACE ${CMAKE_CURRENT_LIST_DIR})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad. Remove it style from your mind

Comment on lines +36 to +42
#
#if(${LINKS_PLATFORM_BENCHMARKS})
# add_executable(${PROJECT_NAME}.Benchmarks ${PROJECT_NAME}.Benchmarks/AllBenchmarks.cpp)
# target_link_libraries(${PROJECT_NAME}.Benchmarks PRIVATE CONAN_PKG::gtest)
# target_link_libraries(${PROJECT_NAME}.Benchmarks PRIVATE CONAN_PKG::benchmark)
# target_link_libraries(${PROJECT_NAME}.Benchmarks PRIVATE ${PROJECT_NAME}.Library)
#endif()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +35 to +38
memset(&createdLink, 0, sizeof(createdLink));
memset(&updatedLink, 0, sizeof(updatedLink));
memset(&foundLink, 0, sizeof(foundLink));
memset(&deletedLink, 0, sizeof(deletedLink));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad. Not bad...

Comment on lines +4 to +7
UInt64Link createdLink;
UInt64Link updatedLink;
UInt64Link foundLink;
UInt64Link deletedLink;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to main, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants