An attempt to speed up insertion for trees.

linksplatform · Mar 23, 2023 · 3f58ce2 · 3f58ce2
1 parent faf2b56
commit 3f58ce2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/csharp/Platform.Collections.Methods/Trees/SizeBalancedTreeMethods.cs b/csharp/Platform.Collections.Methods/Trees/SizeBalancedTreeMethods.cs
@@ -41,12 +41,18 @@ protected override void AttachCore(ref TElement root, TElement node)
                 if (FirstIsToTheLeftOfSecond(node, root))
                 {
                     AttachCore(ref GetLeftReference(root), node);
-                    LeftMaintain(ref root);
+                    if (attachCount > maintainThreashold) 
+                    {
+                        LeftMaintain(ref root);
+                    }
                 }
                 else
                 {
                     AttachCore(ref GetRightReference(root), node);
-                    RightMaintain(ref root);
+                    if (attachCount > maintainThreashold) 
+                    {
+                        RightMaintain(ref root);
+                    }
                 }
             }
         }

diff --git a/csharp/Platform.Collections.Methods/Trees/SizedBinaryTreeMethodsBase.cs b/csharp/Platform.Collections.Methods/Trees/SizedBinaryTreeMethodsBase.cs
@@ -20,6 +20,9 @@ namespace Platform.Collections.Methods.Trees
     /// <seealso cref="GenericCollectionMethodsBase{TElement}"/>
     public abstract class SizedBinaryTreeMethodsBase<TElement>   where TElement: IUnsignedNumber<TElement>, IComparisonOperators<TElement, TElement, bool>
     {
+        protected int attachCount = 0;
+        protected readonly int maintainThreashold = 10;
+
         /// <summary>
         /// <para>
         /// Gets the left reference using the specified node.
@@ -570,6 +573,7 @@ protected virtual void ClearNode(TElement node)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public void Attach(ref TElement root, TElement node)
         {
+            attachCount++;
 #if ENABLE_TREE_AUTO_DEBUG_AND_VALIDATION
             ValidateSizes(root);
             Debug.WriteLine("--BeforeAttach--");
@@ -595,6 +599,10 @@ public void Attach(ref TElement root, TElement node)
                 throw new InvalidOperationException("Tree was broken after attach.");
             }
 #endif
+            if (attachCount > maintainThreashold) 
+            {
+                attachCount = 0;
+            }      
         }
 
         /// <summary>