Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker (TradingBot) #180

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add docker (TradingBot) #180

wants to merge 8 commits into from

Conversation

feelan03
Copy link

@feelan03 feelan03 commented Sep 10, 2022 •
edited
Loading

Add docker build

@feelan03 feelan03 changed the title Small fix Add docker (TradingBot) Sep 10, 2022
Konard
Konard requested changes Sep 10, 2022
View reviewed changes
Copy link
Member

@Konard Konard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove app folder. There is no need to change folder structure for docker only.
We also can add a GitHub Actions workflow for building and publication of docker image.

csharp/TraderBot/.env.example Outdated Show resolved Hide resolved
csharp/TraderBot/app/appsettings.json Outdated Show resolved Hide resolved
csharp/TraderBot/app/appsettings.json Outdated Show resolved Hide resolved
csharp/TraderBot/config.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Konard Konard Konard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feelan03 @Konard @eugenefeel