Fix SchemaView metadata injection and get URI #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame are managed (mostly from_schema and URIs) Signed-off-by: Vincent Kelleher <[email protected]>
vincentkelleher
force-pushed
the
fix_different_types_with_same_name
branch
from
a81859c to
259ecd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue while working on our Gaia-X ontology as there is a slot named
uriand also a type (from LinkML types) nameduri. This caused the metadata injection (overwritingfrom_schemawith the current schema ID) to fail asdicts are used and merged, meaning either the LinkMLuricould get the correct schema ID or the Gaia-Xurislot not both.To fix this I just proposed to merge the values in a list avoiding any collision.
Please note I also fixed the
get_uri(..)method as in the case above I would get aStopIterationexception coming from thenext(..)method arriving at the end of the schema map without finding element. To do so, I just added a default value to the iteration method:next(<generator function>, <fallback/default value>).