Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] swap out bool with is None in induced_slot #331

Merged
merged 8 commits into from
Jul 29, 2024
Merged

[perf] swap out bool with is None in induced_slot #331

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3637573
swap out bool with is None
sneakers-the-rat Jul 24, 2024
652262d
fetch upstream tags and ensure dynamic versioning plugin installed
sneakers-the-rat Jul 26, 2024
d9cbabc
how about just the tags
sneakers-the-rat Jul 26, 2024
6109b42
nope need the plugin explicitly installed
sneakers-the-rat Jul 26, 2024
0cf5c12
upstream dropped support for pydantic 1
sneakers-the-rat Jul 26, 2024
0646a42
add 3.12 bc upstream has it
sneakers-the-rat Jul 26, 2024
42181a7
make exclusions match upstream
sneakers-the-rat Jul 26, 2024
d3b5417
Merge branch 'fix-test-upstream' into perf-bool
sneakers-the-rat Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions linkml_runtime/utils/schemaview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ def induced_slot(self, slot_name: SLOT_NAME, class_name: CLASS_NAME = None, impo
# attributes take priority over schema-level slot definitions, IF
# the attributes is declared for the class or an ancestor
slot_comes_from_attribute = False
if cls:
if cls is not None:
slot = self.get_slot(slot_name, imports, attributes=False)
# traverse ancestors (reflexive), starting with
# the main class
Expand Down Expand Up @@ -1353,7 +1353,7 @@ def induced_slot(self, slot_name: SLOT_NAME, class_name: CLASS_NAME = None, impo
# inheritance of slots; priority order
# slot-level assignment < ancestor slot_usage < self slot_usage
v = getattr(induced_slot, metaslot_name, None)
if not cls:
if cls is None:
propagated_from = []
else:
propagated_from = self.class_ancestors(class_name, reflexive=True, mixins=True)
Expand Down
Loading