Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[router] remove store level metrics for non-streaming multiget #1306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[router] remove store level metrics for non-streaming multiget #1306

wants to merge 1 commit into from

Commits on Nov 15, 2024

  1. [router] remove store level metrics for non-streaming multiget 

    The store level metrics in AggRouterHttpRequestStats are registered lazily.
Add a flag in AggRouterHttpRequestStats to disable store level metric emission
for non-streaming multiget request type. This is cleaner and the less intrusive
than adding checks and handling elsewhere because AggRouterHttpRequestStats and
the triggers to corresponding record functions are shared across different
request types (SINGLE_GET, MULTI_GET, MULTI_GET_STREAMING, COMPUTE, etc...).

We will keep the total stats for non-streaming multiget to give us visibility
in case any legacy clients start to make non-streaming multiget requests.

Fixed a bug where recordNoAvailableReplicaAbortedRetryRequest was calling the
wrong method for the store metric recording.
    @xunyin8
    xunyin8 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a48b556 View commit details
    Browse the repository at this point in the history